Update ncurses to not build a separate libtinfo but provide a soft link instead. Force linking to ncurses in libreadline #5067
Conversation
…nk instead. Force linking to ncurses in libreadline
|
Test report by @ocaisa |
|
Test report by @ocaisa |
| libs = ["form", "menu", "ncurses", "panel", "tinfo"] | ||
| # need to take care of $CFLAGS ourselves with dummy toolchain | ||
| # we need to add -fPIC, but should also include -O* option to avoid compiling with -O0 (default for GCC) | ||
| buildopts = ['CFLAGS="-O2 -fPIC"', 'CFLAGS="-O2 -fPIC"'] |
There was a problem hiding this comment.
you don't need to make this a list, just a string will work (it will be used once for every entry in configopts)
buildopts = 'CFLAGS="-O2 -fPIC"| # we need to add -fPIC, but should also include -O* option to avoid compiling with -O0 (default for GCC) | ||
| buildopts = ['CFLAGS="-O2 -fPIC"', 'CFLAGS="-O2 -fPIC"'] | ||
|
|
||
| # Symlink to ncurses for libtinfo (since it can handle the API) so it doesn't get picked up from the OS |
There was a problem hiding this comment.
I'd rephrase this to symlink libtinfo to libncurses (since ...?
|
Other than the minor remarks, this looks good to me. I don't consider symlinking You mentioned in #3545 (comment) that Debian "has done this in the past". Are you saying they are not doing this anymore, and if so, why not, and what are they doing now? Any references? |
|
Test report by @boegel |
|
Test report by @boegel |
|
I was only reading that from https://bugzilla.redhat.com/show_bug.cgi?id=499837#c2 (which was in 2010), I don't know what the current status is. |
|
Seems like they provide a separate |
|
So do you think we should be doing the same? |
|
@ocaisa No, not really, if this approach works, fine. We had the split |
|
Ok, my bad, I thought you meant to give |
| # for the termcap symbols, use EB ncurses | ||
| preconfigopts = "env LDFLAGS='-lncurses'" | ||
| buildopts += "SHLIB_LIBS='-lncurses'" |
There was a problem hiding this comment.
|
Going in, thanks @ocaisa! |
(created using
eb --new-pr)