Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[system/system] nullarbor v2.0.20191013 #9778

Conversation

manifestoso
Copy link
Contributor

(created using eb --new-pr)

@migueldiascosta migueldiascosta added this to the 4.x milestone Mar 3, 2020
@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/3fc4cb1747cb11bd6f4f09b4d1402d2a for a full test report.

('Miniconda3', '4.7.10', '', True)
]

sanity_check_commands = [('nullarbor.pl', '-h')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is nullarbor.pl --check, but if fails with missing databases, should those also be installed?

Copy link
Contributor Author

@manifestoso manifestoso Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta Thx for pointing --check option. I think it's a duplicate feature as sanity_check checks dir /perl5 which contains perl modules, files checks all binaries.
You probably are right, a more explicit option can be invoked to check each required perl modules.

A complete nullarbor has two parts framework and dataset, this easyconfig only cater framework part. Given the reference database is of a reasonable size 24G altogether and different research may use different reference databases, I would prefer to leave this part to the individual institution. I can append a few lines of instructions at the end, see what you @migueldiascosta think.

@manifestoso
Copy link
Contributor Author

Ping @migueldiascosta can we merge this PR? Thx

@Micket
Copy link
Contributor

Micket commented May 29, 2020

Sorry for the delayed response, with reference to my comment in #10708, we will decline conda-packages in the upstream easyconfig repo.

@Micket Micket closed this May 29, 2020
@manifestoso
Copy link
Contributor Author

manifestoso commented Jun 19, 2020

@Micket

I might think this one may suit for conda contrib, as the source build is quite finicky on dep chains. See how you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants