Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide validation test of git_config argument to easyblock.obtain_file() #3322

Closed
kelseymh opened this issue May 2, 2020 · 1 comment
Closed
Milestone

Comments

@kelseymh
Copy link
Contributor

kelseymh commented May 2, 2020

In PR #3294, @boegel suggested adding an explicit test to verify all the git_config options that can be used in obtain_file().

def obtain_file(self, filename, extension=False, urls=None, download_filename=None, force_download=False,

This would coordinate with the addition of git_config support for extensions, and updating the exts_list documentation (PR #617).

@kelseymh kelseymh changed the title Provide validation test of git_config argument to filetools.obtain_file() Provide validation test of git_config argument to easyblock.obtain_file() May 2, 2020
@kelseymh
Copy link
Contributor Author

kelseymh commented May 3, 2020

The git_config interface is already tested as part of filetools.py

def test_get_source_tarball_from_git(self):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants