-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sections explaining exts_list options, and self.cfg in EasyBlocks #617
Add sections explaining exts_list options, and self.cfg in EasyBlocks #617
Conversation
This should not be merged as it is. It appears that not all of the "build parameters" can be used directly in |
@kelseymh The documentation under the Perhaps it's better to add a subsection in https://easybuild.readthedocs.io/en/latest/Writing_easyconfig_files.html instead? For which parameters are you seeing problems? There indeed are a couple of exceptions, one is |
@boegel wrote:
Oops! Hence the directory name :-/ Okay, I can definitely back that out.
That works for me.
I was having trouble getting the |
Added '(WIP)' to title to reflect that the organization of my changes needs to be modified per @boegel . |
…Extensions in Writing_easyconfig_fils.
…fernences to sources dictionary and git_config.
Fix my various RST mistakes in the new 'Module extensions' section of Writing_easyconfig_files. Remove spurious double-colon, improve indentation in `exts_list` example, add specific example for using `git_config` here (coming as part of Framework PR #3294.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the single comment
@ocaisa One question for you -- should these documentation updates be rolled out before the new feature in Framework PR #3294? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if you don't actually uses tags, we should give one here so the example gives best practice.
@kelseymh I haven't been close enough attention but of course you're right, easybuilders/easybuild-framework#3294 should come first. |
…git_config' directly.
How do I deal with the "codespell" failure on the "Docs build and installation" test? |
Fix the spelling error at https://github.com/easybuilders/easybuild/pull/617/checks?check_run_id=754862987#step:5:17 and add |
@kelseymh argh sorry, Travis ci needs the ignore word as well |
@ocaisa @boegel This PR is still listing "one change requested", but I can't figure out what the change is. Following the "See review" takes me to @ocaisa 's comment about using a tag, rather than a branch or SHA in my example, which I implemented. I'm hoping this could get re-reviewed with the current version so it can roll out to 4.2.2 along with the new code it's documenting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort you've gone to on this @kelseymh , a couple more suggestions but otherwise good to go
…syConfig with easyconfig in new documentation sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going in, thanks @kelseymh !
Following the discussion in EasyBlocks #3266, I've added a paragraph of text under "extensions parameters" explaining what each
exts_list
entry contains, and cross-referencing the "build parameters" section of the file.I tried to use
rst2html
(provided with Python/3.6.6-foss-2018b) to check my work, but it apparently does not process:ref:
directives (e.g.,rst2html Implementing-easyblocks.rst
generated a bunch of error messages).Updated 25 Apr: I am also adding a section to
Implementing-easyblocks.rst
as well, describing how to use theself.cfg
dictionary, per #618 .