only use environment variable to find module command binary if command can't be found in $PATH #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d can't be found in $PATH
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -122,7 +122,7 @@ class ModulesTool(object): | |||
| TERSE_OPTION = (0, '--terse') | |||
| # module command to use | |||
| COMMAND = None | |||
| # environment variable to determine the module command (instead of COMMAND) | |||
| # environment variable that may refer to module command | |||
There was a problem hiding this comment.
missing documentation how it resolves it now.
There was a problem hiding this comment.
docs update at easybuilders/easybuild#119
…LMOD_CMD are different
|
Refer to this link for build results (access rights to CI server needed): |
…ia $PATH, enhance test_lmod_specific unit test
|
Refer to this link for build results (access rights to CI server needed): |
|
Thanks for the review @stdweird! |
boegel
added a commit
that referenced
this pull request
May 6, 2015
only use environment variable to find module command binary if command can't be found in $PATH
boegel
added a commit
that referenced
this pull request
May 6, 2015
only use environment variable to find module command binary if command can't be found in $PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
lmodis found in$PATH, we shouldn't be using the value of$LMOD_CMDto determine the path tolmod.When Lmod is available both on the system and in the user's account, we may end up using the wrong
lmodbinary that way (cfr. Taito @ CSC.fi).