Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix 1342_pgisupport #1537

Closed
wants to merge 4 commits into from

Conversation

jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Jan 8, 2016

See issue: #1536

@hpcugentbot
Copy link

Automatic reply from Jenkins: Can I test this?

@jgphpc jgphpc mentioned this pull request Jan 8, 2016
@@ -0,0 +1 @@
craytoolchain.py-with-swap-fix-gpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a symlink? any particular reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created this symlink for our production installation in order to avoid overwriting the stock craytoolchain.py with our modified version (that it is still under testing).

I suppose that craytoolchain.py should come from PR #2222 and the file+symlink could be removed from this PR.

@boegel
Copy link
Member

boegel commented Jan 9, 2016

@jgphpc: it seems like you included the PGI support from #1342 in here?

It's good to know that others are playing around with it, especially on Cray systems, but we should get #1342 merged first...

From what I can tell, the CraypPGI side of things in here looks OK, except for the symlink I pointed out.

@boegel boegel added this to the v2.6.0 milestone Jan 9, 2016
@boegel boegel modified the milestones: v2.6.0, v2.7.0 Jan 22, 2016
@boegel boegel modified the milestones: v2.8.0, v2.7.0 Mar 9, 2016
@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 18, 2016

@boegel Would it be ok if i close this PR and commit my files to https://github.com/hpcugent/easybuild-framework/pull/1342/files instead ?

@boegel
Copy link
Member

boegel commented Apr 18, 2016

@jgphpc I'm not sure what you're trying to do... #1342 is not your PR, so how will you add your changes there?

I think we should get #1342 merged in first (we're close to that), and then revisit this PR (by updating the branch you used here with develop).

Keeping the CrayPGI changes separate from general PGI support makes sense to me?

@jgphpc jgphpc mentioned this pull request Apr 20, 2016
@jgphpc
Copy link
Contributor Author

jgphpc commented Apr 20, 2016

Will continue in #1729

@jgphpc jgphpc closed this Apr 20, 2016
@jgphpc jgphpc deleted the 1342_pgisupport branch April 20, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants