-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trying to fix 1342_pgisupport #1537
Conversation
Automatic reply from Jenkins: Can I test this? |
@@ -0,0 +1 @@ | |||
craytoolchain.py-with-swap-fix-gpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a symlink? any particular reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this symlink for our production installation in order to avoid overwriting the stock craytoolchain.py with our modified version (that it is still under testing).
I suppose that craytoolchain.py should come from PR #2222 and the file+symlink could be removed from this PR.
@jgphpc: it seems like you included the PGI support from #1342 in here? It's good to know that others are playing around with it, especially on Cray systems, but we should get #1342 merged first... From what I can tell, the |
@boegel Would it be ok if i close this PR and commit my files to https://github.com/hpcugent/easybuild-framework/pull/1342/files instead ? |
@jgphpc I'm not sure what you're trying to do... #1342 is not your PR, so how will you add your changes there? I think we should get #1342 merged in first (we're close to that), and then revisit this PR (by updating the branch you used here with Keeping the |
Will continue in #1729 |
See issue: #1536