-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FFTW from the Cray Toolchain Definition #1585
Conversation
release EasyBuild v2.6.0
…work into cray_no_fftw_in_tc
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2611/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
👍 This fixes (at least) one of our python bugs we have been seeing.. More details coming soon |
👍 I'm confirming that this PR fixes the problems we had with h5py and when performing os calls on compute nodes. It seems that loading fftw modules has some implications on the python behaviour. Since the wrapper links many libraries against fftw, it is a lot of work to narrow down the list and find the guilty here, so it is better to remove it from the toolchain and just load it when really needed. |
The actual problem to fix is hpcugent/vsc-base#216, right? I'm OK with not including FFTW in the Cray toolchains, but that makes them different from the other 'full' toolchains in EB, and will make it harder for some stuff to switch back & forth (although |
@boegel the fftw issue and the hpcugent/vsc-base#216 are unrelated problems We didn't open an issue because it was not clear where this was coming from, we had a few complaints about the Python build with EB and removing fftw fixes most of them. Now it remains only the mpi4py to be fixed 😄 |
@gppezzi: ah, ok, then please clarify what problems you were running into that are fixed with removing FFTW from the toolchains, for future reference (a 🍪 for including error messages) |
We could reproduce the error with a simple test (doing os calls, see below), but a similar problem was reported by a couple of users. Here's one of the error messages we got.
On some builds/systems this simple test was always blocking and other cases it was randomly working (but showing these error messages). |
OK, thanks for the info, let's merge it in. The Cray toolchains are already different from the others in various ways, so it's OK not having FFTW in there imho (especially since the toolchain support does very little extra with FFTW included). Please issue a corresponding PR to redefine the definition of the Cray toolchain easyconfigs (or point me to it, if it's already there). |
Remove FFTW from the Cray Toolchain Definition
Finally here's the list of .so linked against python with and without fftw. IMO there's a lot of bloat there which python is not even using, it is adding more trouble..
|
@boegel I will create new PR for the basic toolchain and add also fftw to the external metadata file. |
This removes FFTW from the Cray toolchain definition. The include original was done because of symmetry reasons with other toolchains. Also at that time we didn't have external modules support and did stuff at runtime within crayfftw.py that the external modules machinery does in a generic way.
We'll just need to update the HPL configs - those ones are the only ones that we supplied that are using FFTW and assumed FFTW to be loaded through toolchain instantiation.