Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle github api pagination when present (WIP) #2776

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

migueldiascosta
Copy link
Member

alternative to #2553

needs vsc-base 2.8.4

@migueldiascosta
Copy link
Member Author

I'm not particularly happy about the parsing of Links and traversing of pages here, it's certainly not pretty and I don't know if it is sufficiently robust. (It would be much cleaner using requests, but I suppose we are avoiding adding it as a dependency.) Open to suggestions/corrections.

@migueldiascosta migueldiascosta changed the title handle github api pagination when present handle github api pagination when present (WIP) Feb 20, 2019
@boegel boegel added this to the next release (3.8.2) milestone Feb 20, 2019
@boegel boegel added the bug fix label Feb 20, 2019
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta This looks fairly OK to me, I don't see a better option w.r.t. grabbing the page count, since they do something very similar in https://developer.github.com/v3/guides/traversing-with-pagination/...

@wpoely86
Copy link
Member

The code on which the rest code from vsc-base is based on has full pagination support since the beginning of this year: mozilla/agithub#49

So we might as well update the code in vsc-base and use that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants