-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle github api pagination when present (WIP) #2776
base: develop
Are you sure you want to change the base?
handle github api pagination when present (WIP) #2776
Conversation
I'm not particularly happy about the parsing of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@migueldiascosta This looks fairly OK to me, I don't see a better option w.r.t. grabbing the page count, since they do something very similar in https://developer.github.com/v3/guides/traversing-with-pagination/...
The code on which the rest code from vsc-base is based on has full pagination support since the beginning of this year: mozilla/agithub#49 So we might as well update the code in vsc-base and use that? |
alternative to #2553
needs
vsc-base
2.8.4