Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for reverse dependencies of installed modules (WIP) #2783
base: develop
Are you sure you want to change the base?
add support for reverse dependencies of installed modules (WIP) #2783
Changes from 1 commit
98550de
8a75c38
f8d7bfe
35b3df1
09b3bb1
6b069ad
6326588
a48c1b8
bdad246
ec2ac3c
153638a
1392970
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this work with a hierarchical scheme (or any scheme that involved extending the module path)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That shouldn't be a problem when using
modules_tool().available()
, which spits out a list of full module names in a hierarchy (i.e. things likeCore/GCC/6.4.0
rather than justGCC/6.4.0
), so you'll see all modules regardless of where they are in the hierarchy...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
purge
is troublesome on some systems, and fairly expensive with Lmod...How about just running this in a subshell, since we only care about the output, not the changes to the environment?
Or use
ml show
(which only gives direct deps though), that would also make it significantly faster...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@migueldiascosta probably a good idea to use
trace=False
here, otherwise you get very amusing output when usingeb --trace
(which is default for me)