make test_find_eb_script more robust in case $EB_SCRIPT_PATH is already set #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akesandgren
reviewed
May 1, 2020
| @@ -2027,19 +2027,35 @@ def makedirs_in_test(*paths): | |||
|
|
|||
| def test_find_eb_script(self): | |||
| """Test find_eb_script function.""" | |||
|
|
|||
| # make sure $EB_SCRIPT_PATH is not set already (used as fallback mechanism in find_eb_script) | |||
| if 'EB_SCRIPT_PATH' in os.environ: | |||
There was a problem hiding this comment.
Don't you need to reset this to the original value at the end of this test?
There was a problem hiding this comment.
The environment is already automatically reset to the original at the end of each test (see tearDown in test/framework/utilities.py).
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.