make flake8 code style checks pass in test/ #3416
Conversation
| flake8 test/ |
There was a problem hiding this comment.
Please do not change this during the sprint. My suggestion is to enable this at the very end for .. Otherwise all other PRs will conflict when changing this too.
Oh and according to GH it is missing the final newline and the trailing slash is not required :)
There was a problem hiding this comment.
In general, I agree.
But in this case, it's fine to leave this in if @wpoely86 bases his work for the easybuild folder on top of this PR (all the changes there can be made in one go, and then linting.yml can be changed to use flake8 ., and we're done?
There was a problem hiding this comment.
Sure if you want to make those dependent PRs but IMO it is easier to verify locally via flake8 and don't change this yet.
There was a problem hiding this comment.
For easyblocks repo, I definitely agree we should hold off touching (actually adding) linting.yml until we're done.
(cfr. easybuilders/easybuild#643)