-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix combination of --copy-ec and --from-pr #3482
Conversation
…s + enhance test to catch the issue
eae7aaf
to
bc2d08e
Compare
@ocaisa This should be good to go now, can you give it another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a typo, will take a deeper look while you fix that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one minor request
also lgtm, fwiw (and more importantly, it works! :) ) |
7877704
to
3ce315a
Compare
This continues from the work done by @ocaisa in #3473, and fixes the combination of
--copy-ec
and--from-pr
.The scope of this PR is pretty big, and I feel it should be split up into several PRs, so I made this a draft PR for now.
High level overview of additional changes:
--copy-files
function so it can be used to implement--copy-ec
(both with and without--from-pr
)enhance copy_files: single file target, error on empty input list, verbose mode #3483fetch_files_from_pr
calls (mostly to significantly speed up tests)cache result of fetch_files_from_pr function #3484locate_files
function toeasybuild.tools.filetools
module which can be leverared indet_easyconfig_paths
functionadd locate_files function to filetools module #3485download_repo
function fromeasybuild.tools.github
module changes working directorydon't change directory in download_repo function in tools.github #3486det_copy_ec_specs
function to leverage frommain.py
--copy-ec
and--try-*
pr_target_account
build option (only really relevant for tests)fixes #3178