-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the CI configuration to use inclusion instead of exclusion #3616
Conversation
This provides more clarity on what exactly is run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Flamefire lgtm, that looks a bit cleaner indeed.
Let's bump to the latest Lmod 8.x while we're at it: Flamefire#7
I'd like to try something more: Avoid the repetition of the lmod version. But what we just need here is something we can access with |
OK! :) |
@Flamefire Once you're happy with the changes, I'll need to re-configure the test configurations that are required to pass (which is why there's a bunch of orange dots sitting there "waiting" right now). |
b2ae014
to
69ce2f7
Compare
I think this works now. What do you think about this approach?
That's a bit shorter but sets those as actual env variables, so my current approach feels "more right" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This provides more clarity on what exactly is run
The jobs have not changed, the following configurations are tested before (and after):