Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't make changes to software installation directory when using --sanity-check-only #3761

Merged
merged 2 commits into from
Jul 2, 2021
Merged

don't make changes to software installation directory when using --sanity-check-only #3761

merged 2 commits into from
Jul 2, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented Jul 2, 2021

fixes #3757

@boegel boegel added the bug fix label Jul 2, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jul 2, 2021
akesandgren
akesandgren requested changes Jul 2, 2021
View reviewed changes
akesandgren
akesandgren approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren enabled auto-merge July 2, 2021 18:15
@akesandgren akesandgren merged commit c32f8d9 into easybuilders:develop Jul 2, 2021
@boegel boegel deleted the fix_sanity_check_only branch July 2, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

--sanity-check-only requires write access to software install dir
2 participants
@boegel @akesandgren