refactor EasyBlock to decouple collecting of information on extension source/patch files from downloading them #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… source/patch files from downloading them (fixes easybuilders#3849) includes deprecating EasyBlock.fetch_extension_sources and replacing it with EasyBlock.collect_exts_file_info
This was referenced Oct 16, 2021
boegel
added a commit
to boegel/easybuild-easyblocks
that referenced
this pull request
Oct 16, 2021
…sion_sources was deprecated in easybuilders/easybuild-framework#3860
akesandgren
reviewed
Oct 17, 2021
akesandgren
reviewed
Oct 17, 2021
akesandgren
reviewed
Oct 17, 2021
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3849
includes deprecating
EasyBlock.fetch_extension_sourcesand replacing it withEasyBlock.collect_exts_file_info