Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we call EasyBlock.patch_step for postinstallpatches #4063

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Aug 18, 2022

(created using eb --new-pr)

fixes #4040

The bundle easyblock patch_step is a no-op:

    def patch_step(self):
        """Patch step must be a no-op for bundle, since there are no top-level sources/patches."""
        pass

and this causes postinstallpatches to fail when used in any easyconfig is a bundle or that derives from that easyblock.

By calling EasyBlock.patch_step() directly we make sure we are calling the correct function and we can use postinstallpatches in a PythonBundle easyconfig.

@branfosj branfosj added this to the next release (4.6.1?) milestone Aug 18, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit f453819 into easybuilders:develop Sep 9, 2022
@branfosj branfosj deleted the 20220818090519_new_pr_eIkQwACdZV branch September 9, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postinstallpatches fail
2 participants