Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print potential errors after running a command only once #4065

Merged
merged 1 commit into from
May 12, 2023
Merged

print potential errors after running a command only once #4065

merged 1 commit into from
May 12, 2023

Conversation

Flamefire
Copy link
Contributor

parse_cmd_output calls parse_log_for_error which outputs potential
errors by default via log.info.
The former then outputs those via log.warning again.
Fix this by passing stdout=False to the latter.
Also minor rewording and variable renaming.

@boegel boegel added the change label Aug 31, 2022
@boegel boegel added this to the 4.x milestone Aug 31, 2022
smoors
smoors reviewed Feb 27, 2023
View reviewed changes
easybuild/tools/run.py Show resolved Hide resolved
easybuild/tools/run.py Show resolved Hide resolved
@Flamefire Flamefire requested a review from smoors May 11, 2023 08:30
smoors
smoors approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Flamefire
Copy link
Contributor Author

@smoors Could you merge those as the only failing checks are the now-removed bootstrap tests? Or shall I rebase to rerun the CI?

@smoors smoors modified the milestones: 4.x, next release (4.7.2) May 12, 2023
@smoors
Copy link
Contributor

smoors commented May 12, 2023

@smoors Could you merge those as the only failing checks are the now-removed bootstrap tests? Or shall I rebase to rerun the CI?

i cannot merge before all tests are green.
just restarted the 2 failing tests. if those fail again, then better to rebase indeed.

@Flamefire
Print potential errors after running a command only once
68d274c 
`parse_cmd_output` calls `parse_log_for_error` which outputs potential
errors by default via `log.info`.
The former then outputs those via `log.warning` again.
Fix this by passing `stdout=False` to the latter.
Also minor rewording and variable renaming.
@Flamefire
Copy link
Contributor Author

They will fail. I rebased.

@smoors
Copy link
Contributor

smoors commented May 12, 2023

Going in, thanks @Flamefire!

@smoors smoors merged commit 7188468 into easybuilders:develop May 12, 2023
@Flamefire Flamefire deleted the error-parse branch May 12, 2023 11:36
@boegel boegel changed the title Print potential errors after running a command only once print potential errors after running a command only once May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

Assignees
No one assigned
Labels
change code cleanup
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Flamefire @smoors @boegel @jfgrimm