fix leaked handles in set_columns, complete_cmd, run_cmd_qa, det_terminal_size functions + tests #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`os.popen` is used without closing the returned handle. As this function is deprecated anyway replace it by `subprocess_popen_text`.
Flamefire
force-pushed
the
fix-leaked-handle
branch
from
4643334
to
e87cecc
Compare
Flamefire
force-pushed
the
fix-leaked-handle
branch
from
e87cecc
to
ed41fca
Compare
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.popenis used without closing the returned handle.As this function is deprecated anyway replace it by
subprocess_popen_text.Also fix some more leaked handles from opened processes and files, extracted from #3790