fix trying to generate RPATH wrappers for Clang #4088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loop is supposed to loop over all compilers for which wrappers need to be created. However, this line returns (['clang', 'clang++'],[None, None, None]) for the
Clang
toolchain. The subsequent call towhich
happening here then fails.This PR fixes that by explicitely checking if
cmd
isNone
. If so, it proceeds to the next loop iteration and doens't try to create an RPATH wrapper for this 'None' command.