Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip GitPython 3.1.28, since it prints 'git' as version which messes up the version check in check_github() #4090

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Oct 10, 2022

Temporary workaround for hard crash when running eb --check-github:

Checking status of GitHub integration...

Making sure we're online...OK

* GitHub user...easybuild_test => OK
* GitHub token...(no token found) => FAIL
* git command...OK ("git version 2.37.3; ")
* GitPython module...OK (GitPython version git)

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmp/runner/27071ea6b2f01bb01ec8a4fe1b156b7ac26b2654/lib/python3.7/site-packages/easybuild/main.py", line 602, in <module>
    main()
  File "/tmp/runner/27071ea6b2f01bb01ec8a4fe1b156b7ac26b2654/lib/python3.7/site-packages/easybuild/main.py", line 287, in main
    check_github()
  File "/tmp/runner/27071ea6b2f01bb01ec8a4fe1b156b7ac26b2654/lib/python3.7/site-packages/easybuild/tools/github.py", line 2089, in check_github
    if LooseVersion(ver) < LooseVersion(req_ver):
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/distutils/version.py", line 52, in __lt__
    c = self._cmp(other)
  File "/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/distutils/version.py", line 337, in _cmp
    if self.version < other.version:
TypeError: '<' not supported between instances of 'str' and 'int'
* push access to easybuild_test/easybuild-easyconfigs repo @ GitHub...

@boegel
Copy link
Member Author

boegel commented Oct 10, 2022

I've reported this problem upstream at gitpython-developers/GitPython#1500 .

Regardless, we should probably make the code in check_github() a bit more robust, in case we're hitting a non-digit GitPython version...

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj branfosj merged commit afa8cdb into easybuilders:develop Oct 10, 2022
@boegel boegel deleted the GitPython_version_mess branch October 10, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants