Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve output produced by --check-github #4437

Merged
merged 1 commit into from
Jan 18, 2024
Merged

improve output produced by --check-github #4437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions easybuild/tools/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2008,17 +2008,18 @@ def check_github():
github_user = build_option('github_user')
github_account = build_option('github_org') or build_option('github_user')

if github_user is None:
check_res = "(none available) => FAIL"
status['--new-pr'] = status['--update-pr'] = status['--upload-test-report'] = False
else:
if github_user:
check_res = "%s => OK" % github_user
else:
check_res = "%s => FAIL" % ('(none available)' if github_user is None else '(empty)')
status['--new-pr'] = status['--update-pr'] = status['--upload-test-report'] = False

print_msg(check_res, log=_log, prefix=False)

# check GitHub token
print_msg("* GitHub token...", log=_log, prefix=False, newline=False)
github_token = fetch_github_token(github_user)
github_token_valid = False
if github_token is None:
check_res = "(no token found) => FAIL"
else:
Expand All @@ -2027,6 +2028,7 @@ def check_github():
token_descr = partial_token + " (len: %d)" % len(github_token)
if validate_github_token(github_token, github_user):
check_res = "%s => OK (validated)" % token_descr
github_token_valid = True
else:
check_res = "%s => FAIL (validation failed)" % token_descr

Expand Down Expand Up @@ -2119,7 +2121,7 @@ def check_github():
try:
getattr(git_repo.remotes, remote_name).push(branch_name, delete=True)
except GitCommandError as err:
sys.stderr.write("WARNING: failed to delete test branch from GitHub: %s\n" % err)
print_warning("failed to delete test branch from GitHub: %s" % err, log=_log)

# test creating a gist
print_msg("* creating gists...", log=_log, prefix=False, newline=False)
Expand All @@ -2137,17 +2139,33 @@ def check_github():

if gist_url and re.match('https://gist.github.com/%s/[0-9a-f]+$' % github_user, gist_url):
check_res = "OK"
else:
elif not github_user:
check_res = "FAIL (no GitHub user specified)"
elif not github_token:
check_res = "FAIL (missing github token)"
elif not github_token_valid:
check_res = "FAIL (invalid github token)"
elif gist_url:
check_res = "FAIL (gist_url: %s)" % gist_url
status['--upload-test-report'] = False
else:
check_res = "FAIL"

if 'FAIL' in check_res:
status['--upload-test-report'] = False
print_msg(check_res, log=_log, prefix=False)

# check whether location to local working directories for Git repositories is available (not strictly needed)
print_msg("* location to Git working dirs... ", log=_log, prefix=False, newline=False)
git_working_dirs_path = build_option('git_working_dirs_path')
if git_working_dirs_path:
check_res = "OK (%s)" % git_working_dirs_path
repos = [GITHUB_EASYCONFIGS_REPO, GITHUB_EASYBLOCKS_REPO, GITHUB_FRAMEWORK_REPO]
missing_repos = [repo for repo in repos if not os.path.exists(os.path.join(git_working_dirs_path, repo))]
if not missing_repos:
check_res = "OK (%s)" % git_working_dirs_path
elif missing_repos != repos:
check_res = "OK (%s) but missing %s (suboptimal)" % (git_working_dirs_path, ', '.join(missing_repos))
else:
check_res = "set (%s) but not populated (suboptimal)" % git_working_dirs_path
else:
check_res = "not found (suboptimal)"

Expand Down
Loading