Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate support for EnvironmentModulesC and EnvironmentModulesTcl module tools #4439

Merged
merged 9 commits into from
Jan 30, 2024

Conversation

branfosj
Copy link
Member

No description provided.

@branfosj branfosj added this to the 5.0 milestone Jan 15, 2024
@boegel boegel changed the title Deprecate EnvironmentModulesC and EnvironmentModulesTcl deprecate EnvironmentModulesC and EnvironmentModulesTcl Jan 17, 2024
@boegel
Copy link
Member

boegel commented Jan 17, 2024

@branfosj We'll need to add self.allow_deprecated_behaviour() in appropriate please, the tests by default fail when they trigger deprecated behavior...

@boegel boegel changed the title deprecate EnvironmentModulesC and EnvironmentModulesTcl deprecate support for EnvironmentModulesC and EnvironmentModulesTcl module tools Jan 22, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jan 22, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jan 22, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jan 23, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 211803d into easybuilders:5.0.x Jan 30, 2024
32 checks passed
@branfosj branfosj deleted the modules branch January 30, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants