Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement EasyBuild API version checks to avoid mixing major versions across the EasyBuild components #4520

Merged
merged 14 commits into from
Jun 5, 2024
Merged

implement EasyBuild API version checks to avoid mixing major versions across the EasyBuild components #4520

merged 14 commits into from
Jun 5, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Apr 27, 2024 •
edited
Loading

This PR will add various version checks and is EB5 prep for the EB4 branch.

  • check that framework and blocks major versions are the same and fails if not
  • check --from-pr / --include-easyblocks-from-pr branches match in use versions

@branfosj branfosj added this to the release after 4.9.1 milestone Apr 27, 2024
@branfosj branfosj marked this pull request as draft April 27, 2024 14:24
@branfosj branfosj changed the title check easyblocks and framework major are the same versions checks to avoid mixing major versions across the EB repositories Apr 27, 2024
boegel
boegel requested changes Apr 29, 2024
View reviewed changes
easybuild/tools/version.py Outdated Show resolved Hide resolved
easybuild/main.py Outdated Show resolved Hide resolved
@branfosj branfosj marked this pull request as ready for review May 6, 2024 13:27
@boegel boegel changed the title versions checks to avoid mixing major versions across the EB repositories versions checks to avoid mixing major versions across the EasyBuild components May 22, 2024
@boegel
improve error message on version mismatch when using --from-pr + rena…
4f7a4e4 
…me UNKNOWN_VERSION to UNKNOWN_EASYBLOCKS_VERSION
@boegel boegel mentioned this pull request Jun 5, 2024
Merged
boegel
boegel requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj see branfosj#10

easybuild/tools/github.py Outdated Show resolved Hide resolved
@branfosj
Merge pull request #10 from boegel/compare_versions
a96ef70 
improve error message on version mismatch when using `--from-pr` + rename `UNKNOWN_VERSION` to `UNKNOWN_EASYBLOCKS_VERSION`
@boegel boegel merged commit 35c7f33 into easybuilders:develop Jun 5, 2024
37 checks passed
@branfosj branfosj deleted the compare_versions branch June 5, 2024 13:47
@boegel boegel changed the title versions checks to avoid mixing major versions across the EasyBuild components implement EasyBuild API version checks to avoid mixing major versions across the EasyBuild components Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @boegel