Deprecate use of parallel easyconfig parameter and fix updating the template value
#4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
changed the title
Flamefire
force-pushed
the
deprecate_parallel-5
branch
from
f714fb3
to
8a76544
Compare
boegel
changed the title
boegel
changed the title
ec['parallel'] and fix updating the template value
Flamefire
force-pushed
the
deprecate_parallel-5
branch
from
8a76544
to
81a2649
Compare
2 tasks
Flamefire
force-pushed
the
deprecate_parallel-5
branch
from
81a2649
to
9e11b40
Compare
ec['parallel'] currently doubles as an EC option and as the storage for the calculated parallelism set by the EasyBlock. This makes it hard to reason about especially as maxparallel has pretty much the same effect. Also changes to ec['parallel'] done by e.g. easyblocks (or the set_parallel method) are not reflected by the template `%(parallel)s` Solution: Introduce a property which on write updates the template and some magic to mirror the effect of the now deprecated ec['parallel']
Migrate from `self.cfg['parallel']` to `self.cfg.parallel`
We need to fix our own easyblocks first but that requires this change. So allow until 5.1 or remove after updating the easyblocks.
The EC parameter is deprecated so the tests fail.
Flamefire
force-pushed
the
deprecate_parallel-5
branch
from
9e11b40
to
1554bd4
Compare
boegel
changed the title
ec['parallel'] and fix updating the template valueparallel easyconfig parameter and fix updating the template value
boegel
reviewed
Nov 6, 2024
| @@ -1212,6 +1229,22 @@ def all_dependencies(self): | |||
|
|
|||
| return self._all_dependencies | |||
|
|
|||
| @property | |||
| def parallel(self): | |||
There was a problem hiding this comment.
@Flamefire Introducing this makes sense, but it means that easyblocks will need to be updated accordingly, right?
There was a problem hiding this comment.
Correct. Should be pretty easy to search for self.cfg['parallel']. I mentioned the need to update the easyblocks in the description which we can only do after merging this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #3842 to 5.0x
ec['parallel'] currently doubles as an EC option and as the storage for the calculated parallelism set by the EasyBlock.
This makes it hard to reason about especially as maxparallel has pretty much the same effect. Also changes to ec['parallel'] done by e.g. easyblocks (or the set_parallel method) are not reflected by the template
%(parallel)sSolution: Introduce a property which on write updates the template and some magic to mirror the effect of the now deprecated ec['parallel']
Additional change I'd like to do: Treat
parallel = False(legacy) asmaxparallel =1socfg.parallelis always a numberSee #3811 (comment) for the motivation
Requires easybuilders/easybuild-easyconfigs#19375 to avoid deprecation warnings
Compared to #3842 I had to move the deprecation to 5.1 as easyblocks need updating but that requires this PR. So either we keep 5.1 as the target or merge this, update the easyblocks, then remove the deprecation (and fail hard) for 5.0