Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let cmd.sh script produced by run_shell_cmd define $EB_CMD_OUT_FILE + $EB_CMD_ERR_FILE #4611

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 16, 2024

$EB_CMD_OUT_FILE is useful to let people easily found the output that was generated by a shell command, since the path to the file containing it is not easy to find

@boegel boegel added this to the 5.0 milestone Aug 16, 2024
@boegel boegel requested a review from Micket August 16, 2024 17:16
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Aug 16, 2024

tested it locally, seems fine

@Micket Micket merged commit abd5ee8 into easybuilders:5.0.x Aug 16, 2024
35 checks passed
@boegel boegel deleted the EB_CMD_OUT_FILE branch August 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants