document --include (REVIEW) #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great feature and has a bunch of different uses. Definitely we want to introduce the simplest uses first (overriding easyblocks and naming schemes) without confusing the reader |
|
@rjeschmi: completed this, up for giving this another look? |
|
It looks fine, it is a pretty big feature. It will take some time to understand problems people have with it. |
|
|
||
| .. _include_general_remarks: | ||
|
|
||
| General aspects of ``--include`` options |
There was a problem hiding this comment.
this should maybe be --include-* just to avoid confusion over a generic --include option.
7 tasks
|
easybuilders/easybuild-framework#1301 is merged in, so this is good to go as well. Thanks @rjeschmi and @fgeorgatos for the feedback here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.