Fixes and improvement when using xformers. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug when 'attn_kwargs' is None.
…nly get the part needed.
cmdr2
reviewed
Dec 26, 2022
| @@ -144,9 +144,8 @@ def __init__(self, arch="ViT-H-14", version="laion2b_s32b_b79k", device="cuda", | |||
| freeze=True, layer="last"): | |||
| super().__init__() | |||
| assert layer in self.LAYERS | |||
| model, _, _ = open_clip.create_model_and_transforms(arch, device=torch.device('cpu'), pretrained=version) | |||
There was a problem hiding this comment.
Is this just a cosmetic change (to remove unused variables), or this this needed for any functional changes?
I'd avoid too much divergence from the stability codebase, even if we don't really agree with the coding style. Ideally I would not have a custom fork at all.
There was a problem hiding this comment.
create_model_and_transforms loads and create image transforms for img2img but they don't use them.
It's faster to just call create_model and only process the part that is needed.
That change is already in a PR waiting to be merged Stability-AI#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.