-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): evaluate simple placeholders as menu title #1460
Conversation
Caution Review failedThe pull request is closed. 总览这些变更涉及菜单配置选项和标题显示的测试和功能实现。在 变更
导出或公共实体声明的变更未对任何导出或公共实体的声明进行修改。 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1460 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 524 524
Lines 15650 15653 +3
Branches 2345 2346 +1
=======================================
+ Hits 13370 13373 +3
Misses 1830 1830
Partials 450 450
|
🚀 Deployed on https://docs-preview-1460--next-bricks.netlify.app |
📐🤏 Size check result (24971fc...4495f7a): error code: 1033 |
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。Summary by CodeRabbit
新功能
smartDisplayForMenuTitle
函数中添加逻辑,以支持根据overrideApp
替换标题中的占位符${APP.name}
和${APP.localeName}
。测试
getMenuConfigOptions
函数的测试覆盖率,添加了新场景。