-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): extract source of contract in contract.yaml #4429
Conversation
next-core Run #10430
Run Properties:
|
Project |
next-core
|
Branch Review |
refs/pull/4429/merge
|
Run status |
Passed #10430
|
Run duration | 00m 27s |
Commit |
96275fdf37 ℹ️: Merge 4701e4c85e73f3aeb88f9cd0b8e8d89e1d42cc95 into d7b2074e03514d338dc1aaeada2d...
|
Committer | Shenwei Wang |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
6
|
View all changes introduced in this branch ↗︎ |
ac00ada
to
4701e4c
Compare
@@ -60,6 +65,7 @@ module.exports = function generateBrickContracts(dir, isProviderBricks) { | |||
.join("-api-")}`, | |||
{ | |||
type: "contract", | |||
source: source || "sdk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为现在 VB 打包时会扫描项目依赖的构件的制品中的 contract.yaml 中记录的依赖契约的信息,然后合并打进 bootstrap.json 中,导致应用 storyboard 中 meta.contracts
字段包含大量并不需要的契约,这包括直接使用 sdk 和 provider 的用法,实际只有使用 useProvider("xx@yy")
才需要,因此增加 source
字段区分,届时打包扫描时忽略存在 source
但 source
不为 contract
的记录。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Janice-shi
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。