Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change behaviour of match argument in data_match() #138

Closed
strengejacke opened this issue Mar 23, 2022 · 1 comment
Closed

change behaviour of match argument in data_match() #138

strengejacke opened this issue Mar 23, 2022 · 1 comment
Labels
Enhancement 💥

Comments

@strengejacke
Copy link
Member

Would be nice if match would not only accept a data frame, but also an expression, or list of expressions. These could then be passed to subset(subset = expr), so we would also have something comparable to dplyr::filter(). The main benefit over R's subset() should be to preserve label attributes.
@strengejacke
Copy link
Member Author

@IndrajeetPatil why do we have two enhancement labels here?

strengejacke added a commit that referenced this issue Mar 23, 2022
@strengejacke
#138
ac2ba9d
@strengejacke strengejacke mentioned this issue Mar 23, 2022
Merged
strengejacke added a commit that referenced this issue Mar 23, 2022
@strengejacke
Data match filter (#139)
23a1301 
* #138

* Update data_match.Rd

* fix check issues, docs

* typo

* wording

* better description

* docs

* data_filter is short-cut, improve see-also

* Update test-labelled_data.R

* data match matches, data filter filters

* Update test-labelled_data.R
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement 💥
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IndrajeetPatil @strengejacke