-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vignette for check model #575
base: main
Are you sure you want to change the base?
Conversation
Maybe we can integrate with #574 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 57.30% 57.50% +0.19%
==========================================
Files 87 87
Lines 6416 6436 +20
==========================================
+ Hits 3677 3701 +24
+ Misses 2739 2735 -4 ☔ View full report in Codecov by Sentry. |
What is not quite clear to me is the demonstration of the relationship between p and pd? Your introduction ends with
The reader now knows why model diagnostic is important, why eye-balling is preferred over statistical tests, which kind of assumptions are important to test, and how to do this (using But then you start with simulations to show the relation between p and pd, and that interpreting p-values is not easy. Why this section? This is not directly related to model diagnostics (regarding show cases of |
Fixes #395