-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/change workflow setup #63
Comments
|
Thanks! How does tidyverse deal with the matrix issue? I don't think we're the only ones facing this problem? |
Only one package relies on Matrix, and looking at its workflow provides no clue. I had already tried changing the cache version, but that didn't work. pak::pkg_deps_explain("tidyverse", "Matrix", dependencies = TRUE)
#> tidyverse -> ggplot2 -> mgcv -> Matrix And our problems are exponentially worse than for any of the tidyverse packages because our packages download a ton of dependencies about statistically modeling (e.g. lme4, glmmTMB, etc.), many of which a require certain binary-compatible Matrix version, which is different across different R versions. |
The partial-matching workflow leads to errors, even if those issues occur in other packages, where we cannot control the behaviour (e.g. https://github.com/easystats/insight/actions/runs/9677160242/job/26698218779?pr=897). This makes (some?) workflows essentially useless. If a failing example is quite at the beginning of this workflows, most of the remaining examples will never be checked. And we cannot "fix" this, because the partial-matching happens in other packages.
Workflows on R <= 4.3 fail since weeks. I think we should at least temporarily disable those workflows. I never look into these errors, because I'm expecting it's the old failure that is not related to my changes. So I will never realize if this workflow is working again and failures are indeed to my changes, because I'm ignoring those workflows right now.
The text was updated successfully, but these errors were encountered: