Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to tracing-subscriber 0.3 #12

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracing-distributed/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use_parking_lot = ["parking_lot"]
[dependencies]
tracing = "0.1.12"
tracing-core = "0.1.9"
tracing-subscriber = "0.2.0"
tracing-subscriber = "0.3"
itertools = "0.9"
parking_lot = { version = "0.11", optional = true }

Expand Down
4 changes: 2 additions & 2 deletions tracing-distributed/src/telemetry_layer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ where
V: 'static + tracing::field::Visit + Send + Sync,
T: 'static + Telemetry<Visitor = V, TraceId = TraceId, SpanId = SpanId>,
{
fn new_span(&self, attrs: &Attributes, id: &Id, ctx: Context<S>) {
fn on_new_span(&self, attrs: &Attributes, id: &Id, ctx: Context<S>) {
let span = ctx.span(id).expect("span data not found during new_span");
let mut extensions_mut = span.extensions_mut();
extensions_mut.insert(SpanInitAt::new());
Expand Down Expand Up @@ -237,7 +237,7 @@ where
parent_id: Some(self.trace_ctx_registry.promote_span_id(parent_id)),
initialized_at,
meta: event.metadata(),
service_name: &self.service_name,
service_name: self.service_name,
values: visitor,
};

Expand Down
2 changes: 1 addition & 1 deletion tracing-honeycomb/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ serde_json = "1"
[dev-dependencies]
tracing-attributes = "0.1.5"
futures-preview = { version = "0.3.0-alpha.19", features = ["compat"] }
tracing-subscriber = "0.2.0"
tracing-subscriber = "0.3.0"
tokio = { version = "0.2", features = ["full"] }
tracing-futures = "0.2.1"
proptest = "0.9.5"