Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-distributed@0.4.0, tracing-honeycomb@0.4.3 - tracing-subscriber 0.3 compatibility + Error impls #14

Merged
merged 11 commits into from
Dec 27, 2021

Conversation

jfhbrook-at-work
Copy link
Contributor

@jfhbrook-at-work jfhbrook-at-work commented Dec 20, 2021

This PR takes #12 and #13 and packages them up into a release branch:

A general release plan taking preroll and our apps into account is in the comments.

Infrasonics and others added 4 commits December 2, 2021 22:14
This is necessary for compatibility with `trait Layer<S>` in tracing-subscriber v0.3.3.
Update dependency to tracing_subscriber 0.3
There's a bug in nightly where the workaround is to run `cargo clean`:

rust-lang/rust#91663
Copy link
Contributor Author

@jfhbrook-at-work jfhbrook-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest question is how to test this - we would need to update the versions in https://github.com/eaze/preroll and then update preroll in one (some?) of our apps.

One way we can do this is to release tracing-distrubuted and preroll with versions 0.4.0-beta.0 and 0.10.0-beta.0 respectively, make an app use those versions, and then go GA when that deploys without major incident.

Does this sound reasonable @ericsampson ?

cc @Infrasonics

.github/workflows/ci.yml Outdated Show resolved Hide resolved
tracing-distributed/Cargo.toml Show resolved Hide resolved
tracing-distributed/src/telemetry_layer.rs Show resolved Hide resolved
@jfhbrook-at-work
Copy link
Contributor Author

jfhbrook-at-work commented Dec 21, 2021

My plan:

  • Release tracing-distributed@0.4.0 (breaking)
  • Release tracing-honeycomb@0.4.3 (additive)
  • PR + release preroll@0.10.0-beta.0 (breaking, beta)
  • Deploy preroll@0.10.0-beta.0 to an internal service, iterate until the service is happy
  • PR + release preroll@0.10.0

As far as I know this PR is ready to go and I feel pretty comfortable with the plan. But I'll sleep on it beforehand, in case either me or someone else has a shower thought.

@jfhbrook-at-work jfhbrook-at-work changed the title Update dependencies to tracing-subscriber 0.3 (Take 2) tracing-distributed@0.4.0, tracing-honeycomb@0.4.3 - tracing-subscriber 0.3 compatibility + Error traits Dec 21, 2021
@jfhbrook-at-work jfhbrook-at-work changed the title tracing-distributed@0.4.0, tracing-honeycomb@0.4.3 - tracing-subscriber 0.3 compatibility + Error traits tracing-distributed@0.4.0, tracing-honeycomb@0.4.3 - tracing-subscriber 0.3 compatibility + Error impls Dec 21, 2021
Copy link

@ceejbot ceejbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it!

.github/workflows/ci.yml Show resolved Hide resolved
Copy link

@ericsampson ericsampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you said makes sense to me for the rationale to specify that both 0.3 and 0.4 of tracing-subscriber are compatible, but I wouldn't mind getting ceej or Chris to double check since I'm not a cargo dep expert yet 😅

Thanks for doing this Josh! We should probably cc the original reporter once the packages are published.

Do you know how to publish the packages?

@jfhbrook-at-work
Copy link
Contributor Author

I don't know how yet, but I'm sure it's a command in cargo and I'm confident that as an owner I'll have the appropriate permissions. I'll try it out today and we'll see!

@Infrasonics
Copy link
Contributor

For checking what gets zipped, have a look at cargo package.
When ready cargo publish does the job. Needs a token for the used registry (e.g. crates.io).

@jfhbrook-at-work jfhbrook-at-work merged commit 6bc5286 into latest Dec 27, 2021
@jfhbrook-at-work jfhbrook-at-work deleted the tracing-subscriber-0.3 branch December 27, 2021 19:49
@jfhbrook-at-work
Copy link
Contributor Author

Published tracing-distributed@0.4.0 and tracing-honeycomb@0.4.3. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants