-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing-distributed@0.4.0, tracing-honeycomb@0.4.3 - tracing-subscriber 0.3 compatibility + Error impls #14
Conversation
This is necessary for compatibility with `trait Layer<S>` in tracing-subscriber v0.3.3.
Update dependency to tracing_subscriber 0.3
There's a bug in nightly where the workaround is to run `cargo clean`: rust-lang/rust#91663
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My biggest question is how to test this - we would need to update the versions in https://github.com/eaze/preroll and then update preroll in one (some?) of our apps.
One way we can do this is to release tracing-distrubuted
and preroll
with versions 0.4.0-beta.0
and 0.10.0-beta.0
respectively, make an app use those versions, and then go GA when that deploys without major incident.
Does this sound reasonable @ericsampson ?
cc @Infrasonics
f988a6a
to
556881d
Compare
This reverts commit 75c62b5.
My plan:
As far as I know this PR is ready to go and I feel pretty comfortable with the plan. But I'll sleep on it beforehand, in case either me or someone else has a shower thought. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐑 it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you said makes sense to me for the rationale to specify that both 0.3 and 0.4 of tracing-subscriber are compatible, but I wouldn't mind getting ceej or Chris to double check since I'm not a cargo dep expert yet 😅
Thanks for doing this Josh! We should probably cc the original reporter once the packages are published.
Do you know how to publish the packages?
I don't know how yet, but I'm sure it's a command in cargo and I'm confident that as an owner I'll have the appropriate permissions. I'll try it out today and we'll see! |
For checking what gets zipped, have a look at |
Published |
This PR takes #12 and #13 and packages them up into a release branch:
A general release plan taking preroll and our apps into account is in the comments.