Fix issue concon121#5

eballetbaz · Sep 15, 2020 · e366edf · e366edf
1 parent 23e5895
commit e366edf
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/naming.js b/naming.js
@@ -75,16 +75,18 @@ module.exports = {
     fixLogGroups(args) {
         var cft = this.serverless.service.provider.compiledCloudFormationTemplate
         var role = cft.Resources.IamRoleLambdaExecution
-        for (var policy of role.Properties.Policies) {
-            for (var statement of policy.PolicyDocument.Statement.filter((s) => (s.Action.includes("logs:CreateLogStream") || s.Action.includes("logs:PutLogEvents")))) {
-                statement.Resource = statement.Resource.filter(function(value, index, arr) {
-                    return Object.values(value).filter(function (v) { return v.includes("log-group") }).length === 0;
-                });
+        if (role) {
+            for (var policy of role.Properties.Policies) {
+                for (var statement of policy.PolicyDocument.Statement.filter((s) => (s.Action.includes("logs:CreateLogStream") || s.Action.includes("logs:PutLogEvents")))) {
+                    statement.Resource = statement.Resource.filter(function(value, index, arr) {
+                        return Object.values(value).filter(function (v) { return v.includes("log-group") }).length === 0;
+                    });
 
-                for (var resource of Object.keys(cft.Resources).filter((r) => r.includes("LogGroup"))) {
-                    statement.Resource.push({
-                        "Fn::Sub": "arn:aws:logs:${AWS::Region}:${AWS::AccountId}:log-group:${" + resource + "}:*" + (statement.Action.includes("logs:PutLogEvents") ? ":*" : "")
-                    })
+                    for (var resource of Object.keys(cft.Resources).filter((r) => r.includes("LogGroup"))) {
+                        statement.Resource.push({
+                            "Fn::Sub": "arn:aws:logs:${AWS::Region}:${AWS::AccountId}:log-group:${" + resource + "}:*" + (statement.Action.includes("logs:PutLogEvents") ? ":*" : "")
+                        })
+                    }
                 }
             }
         }