Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bbb_docker_python_version variable #372

Closed

Conversation

simoncolincap
Copy link

Fixes #371 by setting a specific version for the Docker Python package.

@BrutalBirdie
Copy link
Collaborator

Hmm something is up the full deployment test.
Need to check that out.

@cherbst
Copy link

cherbst commented Dec 23, 2023

Having the same problem

@GUFFMHRZ
Copy link

GUFFMHRZ commented Dec 28, 2023

Same here, Nodes get thrown out of monitoring after running the role including the PR

@berott
Copy link
Contributor

berott commented Dec 30, 2023

is it correct, that this PR merges into bbb/2.6? I have the same problem with bbb/2.7

@BrutalBirdie BrutalBirdie changed the base branch from bbb/2.6 to master December 30, 2023 18:28
@BrutalBirdie
Copy link
Collaborator

is it correct, that this PR merges into bbb/2.6? I have the same problem with bbb/2.7

Oh! Did not even notice that. Yes right, should actually be merged against the master branch.
I have adjusted that.

@BrutalBirdie
Copy link
Collaborator

@BrutalBirdie
Copy link
Collaborator

@cherbst and @GUFFMHRZ
I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set?
Because I just run with this PR diff applied with no issues.

@berott
Copy link
Contributor

berott commented Dec 31, 2023

I use the following monitoring-configuration:

    bbb_monitoring_all_in_one_enable: true
    bbb_monitoring_all_in_one_grafana: false
    bbb_monitoring_all_in_one_prometheus: false
    bbb_monitoring_recordings_from_disk: false
    bbb_monitoring_external: true
    bbb_monitoring_htpasswd_user: "{{bbb_mon_user}}"
    bbb_monitoring_htpasswd: "{{bbb_mon_pass}}"
    bbb_monitoring_systemd_enable: false

Temporary I changed the docker-version manually (based on the information of this PR), after that it runs correctly:

- name: Install python docker packages
  pip:
    name:
      - docker==6.1.3
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"

@GUFFMHRZ
Copy link

GUFFMHRZ commented Dec 31, 2023

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

Hi,
we're running:

- name: Install python docker packages
  pip:
    name:
      - docker=={{ bbb_docker_python_version }}
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"
# https://pypi.org/project/docker/#history
bbb_docker_python_version: 6.1.3
# https://pypi.org/project/docker-compose/#history
bbb_docker_compose_version: 1.29.2

and

bbb_monitoring_all_in_one_enable: yes
bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_exporter_version: latest
bbb_monitoring_external: true

berott pushed a commit to viralitygmbh/ansible-role-bigbluebutton that referenced this pull request Dec 31, 2023
@GUFFMHRZ
Copy link

GUFFMHRZ commented Jan 1, 2024

Temporary I changed the docker-version manually (based on the information of this PR), after that it runs correctly:

- name: Install python docker packages
  pip:
    name:
      - docker==6.1.3
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"

This did not help us

@cherbst
Copy link

cherbst commented Jan 2, 2024

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

What I meant to say was that this PR fixes the problem in #371, not that I have a problem with this PR.
We have

bbb_monitoring_all_in_one_enable: true

and none of the other monitoring settings.

@BrutalBirdie
Copy link
Collaborator

BrutalBirdie commented May 23, 2024

Sorry for not doing anything here for so long.
But now I finally hit this rock again :D

Came back to the issue and starting thinking.
We should switch to community.docker.docker_compose_v2

Since it only needs:

Docker CLI with Docker compose plugin 2.18.0 or later

    PyYAML if [definition](https://docs.ansible.com/ansible/latest/collections/community/docker/docker_compose_v2_module.html#ansible-collections-community-docker-docker-compose-v2-module-parameter-definition) is used

and the pip package can be gone.

Thoughts?

EDIT:
After looking at the old version, it has been marked as DEPRECATED anyway :)
So I will close this PR and push a new one with the new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - All in one monitoring doesn't work with the latest Docker Pip package
5 participants