SoftDelete entities are hard deleted on orphan removal

[Ichtil]

Expected behavior

Statefully replacing field that is @OneToOne(cascade = CascadeType.ALL, orphanRemoval = true) should result in the old value having the soft delete column updated to true.

Actual behavior

The old value is hard deleted (delete from)

Steps to reproduce

Please see attached unit test. The unit test repository is running ebean version 13.6.5 (for newer versions there are some breaking changes), but this bug is happening in our application on the version 13.11.1.

[Ichtil]

#2949

[Ichtil]

We have had some issues with soft delete before (#2727 and #2750), but they should be fixed in the version 13.6.5, so this looks like a different issue.

[Ichtil]

Ok, on second look, I had an old forked version of the repository, sorry for the confusion. I cannot get maven to import the project to the newest version. I'll look at it later.

[Ichtil]

To clear up the confusion - this bug happens on version 13.11.2, the current repo version of 13.11.3-SNAPSHOT couldn't be imported by maven. Could you please have a look at the reported bug?

[Ichtil]

This could be related to #2952

[rbygrave]

So in version 11.22.9 Issue #1505 added the code ...de9823b#diff-b252eeaf218f406dfa45c3497ea358735b864214080d3ff07bccc72bd68f2cccR906

... and that true flag there on that delete() method means delete permanent. Turning that to false makes it a "normal delete" which is then changed to a soft delete if the entity in question has soft delete support.

That is, we have had this bug since 11.22.9 when that code was introduce rather than this being a regression.