Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for #154 - @OrderBy on a @OneToMany property is not used when lazy loading #272

Merged
merged 1 commit into from
May 7, 2015

Conversation

rlamarche
Copy link

This fix is mainly for 3.3 branch (does not exists) which is used in Play Framework 2.3.x

Conflicts:
src/main/java/com/avaje/ebeaninternal/server/deploy/BeanPropertyAssocMany.java
src/test/java/com/avaje/tests/query/orderby/TestOrderByWithMany.java

…y loading

Conflicts:
	src/main/java/com/avaje/ebeaninternal/server/deploy/BeanPropertyAssocMany.java
	src/test/java/com/avaje/tests/query/orderby/TestOrderByWithMany.java
@rbygrave
Copy link
Member

rbygrave commented May 7, 2015

Apologies for the delay. I was pondering the issues of backporting etc and at some stage just dropped the ball on this merge request.

rbygrave added a commit that referenced this pull request May 7, 2015
Backport fix for #154 - @orderby on a @onetomany property is not used when lazy loading
@rbygrave rbygrave merged commit c766793 into ebean-orm:develop-v3 May 7, 2015
@jbcpollak
Copy link

Any chance we could have a 3.3.3 release sometime soon?

@rbygrave
Copy link
Member

So what you'd like is just another release from the develop-v3 branch to go into maven central as 3.3.3.

That is it right - or have I misunderstood?

@jbcpollak
Copy link

Yes, that would be perfect. We are using 3.3.2 and I'm reluctant to upgrade
to 4.7.x but we need the OrderBy fix.

On Thu, Jun 18, 2015, 6:43 PM Rob Bygrave notifications@github.com wrote:

So what you'd like is just another release from the develop-v3 branch to
go into maven central as 3.3.3.

That is it right - or have I misunderstood?


Reply to this email directly or view it on GitHub
#272 (comment)
.

Joshua Chaitin-Pollak
Chief Technology Officer
Assured Labor, Inc.
www.assuredlabor.com
www.empleolisto.com.mx
www.trabalhoja.com.br

@rbygrave
Copy link
Member

Ok, easy then - I should be able to release that this weekend, maybe tonight.
I'll post in here when that is done.

@rbygrave rbygrave added this to the 3.3.3 milestone Jun 18, 2015
@rbygrave rbygrave added the bug label Jun 18, 2015
@rbygrave rbygrave self-assigned this Jun 18, 2015
@jbcpollak
Copy link

Fantastic, and thank you for the rapid response!

On Thu, Jun 18, 2015, 7:15 PM Rob Bygrave notifications@github.com wrote:

Ok, easy then - I should be able to release that this weekend, maybe
tonight.

I'll post in here when that is done.


Reply to this email directly or view it on GitHub
#272 (comment)
.

Joshua Chaitin-Pollak
Chief Technology Officer
Assured Labor, Inc.
www.assuredlabor.com
www.empleolisto.com.mx
www.trabalhoja.com.br

@rlamarche
Copy link
Author

Thank you !

@rbygrave rbygrave modified the milestones: 3.4.2, 3.3.3 Jun 19, 2015
@rbygrave
Copy link
Member

Ok, that has been released and is on it's way to maven central.

Note that this release was version 3.4.2 (so not 3.3.3) - hopefully that is ok / expected your end.

Cheers, Rob.

@jbcpollak
Copy link

great, we will give it a shot, thanks!

On Fri, Jun 19, 2015 at 4:22 AM Rob Bygrave notifications@github.com
wrote:

Ok, that has been released and is on it's way to maven central.

Note that this release was version 3.4.2 (so not 3.3.3) - hopefully that
is ok / expected your end.

Cheers, Rob.


Reply to this email directly or view it on GitHub
#272 (comment)
.

Joshua Chaitin-Pollak
Chief Technology Officer
Assured Labor, Inc.
www.assuredlabor.com
www.empleolisto.com.mx
www.trabalhoja.com.br

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants