Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InTuples literal mode - don't cache ebean compiled query plan #3166

Merged
merged 2 commits into from
Aug 17, 2023
Merged

InTuples literal mode - don't cache ebean compiled query plan #3166

merged 2 commits into from
Aug 17, 2023

Conversation

rob-bygrave
Copy link
Contributor

  • Don't cache ebean compiled query plan when InTuples goes into literal mode
  • Postgres maxInBinding = 32_000;
  • SQLite maxInBinding = 800;
  • Note that not caching the compiled query plan means that metrics visitor isn't going to see it, we lose collection of that query execution metric. We might need a plan to fix this later.

@rob-bygrave
InTuples literal mode - don't cache ebean compiled query plan
76c889c 
- Don't cache ebean compiled query plan when InTuples goes into literal mode
- Postgres maxInBinding = 32_000;
- SQLite maxInBinding = 800;
- Note that not caching the compiled query plan means that metrics visitor isn't
  going to see it, we lose collection of that query execution metric. We might
  need a plan to fix this later.
@rob-bygrave
Test TestInTuplesWithLocalDate does not support SQLServer and DB2 yet
9bcd189
@rob-bygrave rob-bygrave added this to the 13.20.2 milestone Aug 17, 2023
@rob-bygrave rob-bygrave self-assigned this Aug 17, 2023
@rob-bygrave rob-bygrave merged commit 9331050 into master Aug 17, 2023
@rob-bygrave rob-bygrave deleted the feature/InTuples-Literal-skipCache branch August 17, 2023 03:34
rbygrave added a commit that referenced this pull request Aug 21, 2023
@rbygrave
#3166 Remove InTuples literal mode
56550a9
rbygrave added a commit that referenced this pull request Aug 21, 2023
@rbygrave
#3166 Remove InTuples literal mode, remove related plan useCache()
cfb6f0a
rbygrave added a commit that referenced this pull request Aug 21, 2023
@rbygrave
Merge pull request #3177 from ebean-orm/feature/remove-InTuples-liter…
019ef43 
…al-mode

#3166 Remove InTuples literal mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rob-bygrave rob-bygrave

Labels
None yet
Projects
None yet
Milestone
13.21.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rob-bygrave