Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Refactored delete-by-id #3178

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented Aug 21, 2023

No description provided.


private List<Object> findIdsByParentId(Object parentId, Transaction t) {
public List<Object> findIdsByParentId(Object parentId, Transaction t, boolean hard) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing override: Check if abstract method def. is OK

@rbygrave
Copy link
Member

Is this still in DRAFT ?

@rPraml
Copy link
Contributor Author

rPraml commented Aug 22, 2023

This PR and some other fixes are in #3179
So, if #3179 is OK for you, this PR would be obsolete.
If you keep things in separate PRs, I can backport the changes from #3179 to this PR and solve merge conflicts in #3179 after merging this PR.

@rbygrave rbygrave merged commit d9d09b3 into ebean-orm:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants