Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jakarta] Use glassfish jaxb instead of old com.sun jaxb #3224

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented Sep 19, 2023

Hello Rob, as we are using ebean with spring 3 + jakarta in our application, we noted, that we will bundle the old jaxb-impl and the glassfish jaxb-runtime.

I did not spot out the exact difference, but https://mvnrepository.com/artifact/com.sun.xml.bind/jaxb-impl is called Old JAXB Runtime module - so I think it is not recommended to use any more.

I also do not know, if the glassfish-jaxb runs in javax mode. Maybe the dependency in ebean-ddl-generator could be removed completely and the user has to provide one of the two libraries.

@jnehlmeier
Copy link

For Java 17 you need Glassfish jaxb-runtime anyways. The old one produces errors with Java 17.

@rPraml
Copy link
Contributor Author

rPraml commented Sep 19, 2023

The old one produces errors with Java 17.

it was not the case here. Maybe, because both were on the classpath.

@rbygrave
Copy link
Member

Nice, this is a good fix.

Maybe the dependency in ebean-ddl-generator could be removed completely and the user has to provide one of the two libraries.

My expectation is that ebean-ddl-generator is generally a test scope dependency and I think the right thing to do is to keep the dependency.

@rbygrave rbygrave added this to the 13.22.1 milestone Sep 19, 2023
@rbygrave rbygrave added the bug label Sep 19, 2023
@rbygrave rbygrave merged commit b445857 into ebean-orm:master Sep 19, 2023
@rbygrave rbygrave changed the title use glassfish jaxb instead of old com.sun jaxb [jakarta] Use glassfish jaxb instead of old com.sun jaxb Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants