Transaction setReadOnly

ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java

@@ -148,6 +148,13 @@ public void initTransIfRequired() {
     persistCascade = transaction.isPersistCascade();
   }
 
+  /**
+   * Mark the underlying transaction as not being query only.
+   */
+  public void markNotQueryOnly() {
+    transaction.markNotQueryOnly();
+  }
+
   /**
    * Return the type of this request. One of INSERT, UPDATE, DELETE, UPDATESQL or CALLABLESQL.
    */

ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java

@@ -87,6 +87,7 @@ public int executeOrmUpdate(Update<?> update, Transaction t) {
   private int executeOrQueue(PersistRequest request) {
     try {
       request.initTransIfRequired();
+      request.markNotQueryOnly();
       int rc = request.executeOrQueue();
       request.commitTransIfRequired();
       return rc;
@@ -383,6 +384,7 @@ public void update(EntityBean entityBean, Transaction t) {
     req.checkDraft();
     try {
       req.initTransIfRequiredWithBatchCascade();
+      req.markNotQueryOnly();
       if (req.isReference()) {
         // its a reference so see if there are manys to save...
         if (req.isPersistCascade()) {
@@ -430,6 +432,7 @@ public void insert(EntityBean bean, InsertOptions insertOptions, Transaction t)
     }
     try {
       req.initTransIfRequiredWithBatchCascade();
+      req.markNotQueryOnly();
       insert(req);
       req.resetDepth();
       req.commitTransIfRequired();
@@ -562,6 +565,7 @@ private int deleteRequest(PersistRequestBean<?> req, PersistRequestBean<?> draft
     }
     try {
       req.initTransIfRequiredWithBatchCascade();
+      req.markNotQueryOnly();
       int rows = delete(req);
       if (draftReq != null) {
         // delete the 'draft' bean ('live' bean deleted first)

ebean-core/src/main/java/io/ebeaninternal/server/transaction/JdbcTransaction.java

@@ -417,6 +417,10 @@ public final void depthReset() {
   @Override
   public final void markNotQueryOnly() {
     this.queryOnly = false;
+    // if the transaction is readonly, it should not allow updates/deletes
+    if (localReadOnly){
+      throw new IllegalStateException("This transaction is read-only");
+    }
   }
 
   @Override

ebean-test/src/test/java/org/tests/transaction/TestTransactionReadOnly.java

@@ -0,0 +1,122 @@
+package org.tests.transaction;
+
+import io.ebean.DB;
+import io.ebean.Transaction;
+import io.ebean.xtest.BaseTestCase;
+import org.junit.jupiter.api.Test;
+import org.tests.model.basic.Country;
+import org.tests.model.basic.Customer;
+import org.tests.model.basic.OrderDetail;
+import org.tests.model.basic.ResetBasicData;
+
+import java.util.Arrays;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+public class TestTransactionReadOnly extends BaseTestCase {
+
+  @Test
+  public void testReadOnlyTransactionWithUpdateQuery() {
+
+    ResetBasicData.reset();
+
+    try (Transaction txn = DB.beginTransaction()) {
+      txn.setReadOnly(true);
+
+      assertThatThrownBy(() -> DB.update(Customer.class).set("name", "Rob2").where().eq("name", "Rob").update())
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.sqlUpdate("update o_customer set name = ? where name = ?")
+        .setParameter(1, "Rob2")
+        .setParameter(2, "Rob").execute())
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.createUpdate(Customer.class, "update customer set name = ? where name = ?")
+        .setParameter(1, "Rob2")
+        .setParameter(2, "Rob").execute())
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      Customer customer = DB.find(Customer.class).where().eq("name", "Rob").findOne();
+      customer.setName("Rob2");
+      assertThatThrownBy(() ->  DB.save(customer))
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      txn.commit();
+    }
+
+  }
+
+  @Test
+  public void testReadOnlyTransactionWithDeleteQuery() {
+
+    ResetBasicData.reset();
+
+    try (Transaction txn = DB.beginTransaction()) {
+      txn.setReadOnly(true);
+
+      assertThatThrownBy(() -> DB.find(OrderDetail.class).where().eq("id", 1).delete())
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.sqlUpdate("delete o_order_detail where id = ?")
+        .setParameter(1, 1).execute())
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.createUpdate(OrderDetail.class, "delete o_order_detail where id = ?")
+        .setParameter(1, 1).execute())
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      OrderDetail orderDetail = DB.find(OrderDetail.class).where().eq("id", 1).findOne();
+      assertThatThrownBy(() ->  DB.delete(orderDetail))
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.deleteAll(Arrays.asList(orderDetail)))
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      txn.commit();
+    }
+
+  }
+
+  @Test
+  public void testReadOnlyTransactionWithInsertQuery() {
+
+    ResetBasicData.reset();
+
+    try (Transaction txn = DB.beginTransaction()) {
+      txn.setReadOnly(true);
+
+      Country country = new Country();
+      country.setName("Germany");
+      country.setCode("DE");
+
+      assertThatThrownBy(() ->  DB.save(country))
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.saveAll(country))
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.insert(country))
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      assertThatThrownBy(() ->  DB.insertAll(Arrays.asList(country)))
+        .isInstanceOf(IllegalStateException.class)
+        .hasMessageContaining("This transaction is read-only");
+
+      txn.commit();
+    }
+
+  }
+
+}