fix: Vapor upload issues #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix using setFileNameCallback/setNameCallback with files uploaded through Vapor - fix generating url for private files using temporaryUrl - fix selecting the wrong bucket when we have different disk for media library based on vapor SignedStorageUrlController https://github.com/laravel/vapor-core/blob/2.0/src/Http/Controllers/SignedStorageUrlController.php
|
I can confirm this appears to fix Vapor upload issues. There's an additional issue when using Laravel Sail's MinIO container for local S3 simulation; the temporary URLs generated use the Minor side note: @sleimanx2, can you fix the misspelling in |
|
let me know when this is ready to merge. |
this allows us to avoid the AWS_LAMBDA_FUNCTION_VERSION check
|
updated 👍🏼 |
|
@sleimanx2 can you create a PR targetting 4.x also? |
Gompje
pushed a commit
to DaktaDeo/advanced-nova-media-library
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on vapor
SignedStorageUrlController