Fix issues loading translations #391
Conversation
|
@bkintanar This looks like a nice addition. Any reasons to not merge this? As far as I know, all frontend fields use the Vue translation helpers. Loading translations from a vendor-override location would enable users to keep translations for |
| protected function loadTranslations() | ||
| { | ||
| $this->loadJSONTranslationsFrom(__DIR__ . '/../resources/lang'); | ||
| $this->loadJSONTranslationsFrom(resource_path('lang/vendor/advanced-nova-media-library')); |
There was a problem hiding this comment.
Use lang_path('vendor/advanced-nova-media-library') instead of resource_path('lang/vendor/advanced-nova-media-library'), as users might have configured a different path for their translations.
| $locale = $this->app->getLocale(); | ||
|
|
||
| Nova::translations(__DIR__ . "/../resources/lang/{$locale}.json"); | ||
| Nova::translations(resource_path("lang/vendor/advanced-nova-media-library/$locale.json")); |
There was a problem hiding this comment.
Use lang_path('vendor/advanced-nova-media-library') instead of resource_path('lang/vendor/advanced-nova-media-library'), as users might have configured a different path for their translations.
* Fix issues loading translations * Replace `resource_path` by `lang_path`
No description provided.