#337 Fix uploads with nested resources and multiple panels #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a media upload is submitted from a parent resource form (e.g. media is associated on a user’s profile, but you want to edit the whole user from the user resource form), this ensures that the media upload is properly associated. Signed-off-by: Tobias Grasse <tg@glancr.de>
Signed-off-by: Tobias Grasse <tg@glancr.de>
Same prefix key logic as in c57633b Signed-off-by: Tobias Grasse <tg@glancr.de>
|
I updated my fork to also handle custom properties for nested forms / panels. |
bkintanar
pushed a commit
that referenced
this pull request
Aug 24, 2023
* #337 Add TODO for deprecated interface Illuminate\Contracts\Validation\Rule was deprecated in laravel/framework v10, should be replaced with ValidationRule once the minimum required version is 10. Signed-off-by: Tobias Grasse <tg@glancr.de> * #337 Pass requestAttribute down to media handling functions Both `addNewMedia` and `addExistingMedia` also call `HandlesExistingMediaTrait::fillMediaCustomPropertiesFromRequest` which requires `$requestAttribute` for nested forms since 079b866 Signed-off-by: Tobias Grasse <tg@glancr.de> * #337 Formatting, reorder imports, add @throws tag Signed-off-by: Tobias Grasse <tg@glancr.de> --------- Signed-off-by: Tobias Grasse <tg@glancr.de>
Gompje
pushed a commit
to DaktaDeo/advanced-nova-media-library
that referenced
this pull request
Mar 29, 2024
…s#407) * ebess#337 Fix uploads with nested resources and multiple panels When a media upload is submitted from a parent resource form (e.g. media is associated on a user’s profile, but you want to edit the whole user from the user resource form), this ensures that the media upload is properly associated. Signed-off-by: Tobias Grasse <tg@glancr.de> * ebess#337 Update import order Signed-off-by: Tobias Grasse <tg@glancr.de> * ebess#337 Handle nested forms and multiple panels Same prefix key logic as in c57633b Signed-off-by: Tobias Grasse <tg@glancr.de> --------- Signed-off-by: Tobias Grasse <tg@glancr.de>
Gompje
pushed a commit
to DaktaDeo/advanced-nova-media-library
that referenced
this pull request
Mar 29, 2024
* ebess#337 Add TODO for deprecated interface Illuminate\Contracts\Validation\Rule was deprecated in laravel/framework v10, should be replaced with ValidationRule once the minimum required version is 10. Signed-off-by: Tobias Grasse <tg@glancr.de> * ebess#337 Pass requestAttribute down to media handling functions Both `addNewMedia` and `addExistingMedia` also call `HandlesExistingMediaTrait::fillMediaCustomPropertiesFromRequest` which requires `$requestAttribute` for nested forms since 079b866 Signed-off-by: Tobias Grasse <tg@glancr.de> * ebess#337 Formatting, reorder imports, add @throws tag Signed-off-by: Tobias Grasse <tg@glancr.de> --------- Signed-off-by: Tobias Grasse <tg@glancr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a media upload is submitted from a parent resource form (e.g. media is associated on a user’s profile, but you want to edit the whole user from the user resource form), this ensures that the media upload is properly associated.
This PR implements the change suggested by @aqjw in #337.
I also tested that the upload still works when submitted directly from the resource form where the media collection is defined (i.e. from the user's profile resource edit form).