-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile error when building via zig build #394
Comments
Ah, seems this may be related to a Zig issue: ziglang/zig#20414 Not for certain, still combing through everything. |
What is the command that you are using to build |
Version:
The actual specific underlying command used is a
|
Hmm, looking at the diff between the |
You really should ask the Zig developers to deobfuscate the compiler command lines they use. But yes, This can be handled in libdeflate by adding It is annoying, but in order to add AVX10/256 support the same compiler versions are going to need It may be a good idea to ask the Zig developers to stop explicitly disabling |
libdeflate failed to build with -mno-evex512 with clang 18+ or gcc 14+ because that flag causes the evex512 feature (which is new in those compiler versions) to have to be explicitly added to functions that use AVX512 with 512-bit vectors. Add this feature where appropriate. For the same compiler versions, also add no-evex512 to the functions that use AVX512 + 256-bit vectors so that they are ready for AVX10/256. Resolves #394
I'm not entirely sure if this is an issue for upstream, but since libdeflate advertises that it's able to be built via just copying the source files into your project, I was hoping you might able to advise/determine whether an upstream fix is needed.
The primary relevant error seems to be
always_inline function '<compiler intrinsic>' requires target feature 'evex512', but would be inlined into function '<function>' that is compiled without support for 'evex512'
(see error log attached below for specific examples) and indeed, if the project is built withzig build -Dcpu=baseline+evex512
it compiles without issue.I'm not an expert when it comes to working with cpu-specific features, but it seems to me that perhaps "evex512" needs to be added to some
_target_attribute
lists (such as here? I'm not exactly sure why building with clang viazig build
would cause this issue to show up when libdeflate (aiui) builds with clang normally without issues, however, which is making me not particularly confident in my answer.Error log
The text was updated successfully, but these errors were encountered: