lib/x86/adler32: add an AVX-512 implementation #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ebiggers
commented
Feb 21, 2024
•
ebiggers
commented
- ci.yml: ensure MSVC can find zlib
- lib/x86: disambiguate 512-bit vector from AVX-512F
- lib/x86: fix XCR0 check for AVX-512VL
- lib/x86/adler32: add an AVX-512 implementation
ebiggers
force-pushed
the
dev
branch
5 times, most recently
from
4f5c559 to
a327744
Compare
ebiggers
changed the title
ebiggers
force-pushed
the
dev
branch
2 times, most recently
from
5bb78a5 to
d44bb93
Compare
crc32_x86_vpclmulqdq_avx512vl and crc32_x86_vpclmulqdq_avx512f_avx512vl actually use the same CPU features, considering that vpternlog always requires at least avx512f, and compilers consider avx512vl to imply avx512f. Rename them to *_avx512_vl256 and *_avx512_vl512 to reflect that they differ only in vector length, and fix the CPU feature checking to use a separate flag for whether 512-bit vectors are enabled.
According to the Intel manual, the ZMM_Hi256 bit needs to be checked for all AVX-512 instructions, even if 512-bit vectors aren't being used.
libdeflate used to (before commit 416bac3) have an AVX512BW implementation of Adler-32, but I removed it due to AVX-512's downclocking issues. Since then, newer Intel and AMD CPUs have come out with better AVX-512 implementations, and these CPUs tend to have AVX512VNNI which includes a dot product instruction which is useful for Adler-32. Therefore, add an AVX512VNNI/AVX512BW implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.