Add support for NetBSD #268

TotallyGamerJet · 2024-08-18T17:42:51Z

What issue is this addressing?

Close #249

What type of issue is this addressing?

feature

What this PR does | solves

Allows cross/compiling with purego on NetBSD

dlfcn_test.go

.github/workflows/test.yml

The example still has the dependency on golang.org/x/sys. Updates ebitengine#270

Updates ebitengine#273

Closes ebitengine#270

TotallyGamerJet · 2024-10-15T00:07:08Z

@0-wiz-0 I'm trying to finish up this PR so it can be merged but I can't figure out how to install go in the NetBSD environment. Could you look at the test.yml file?

0-wiz-0 · 2024-10-15T07:37:40Z

Thank you for working on this, @TotallyGamerJet !
I looked at test.yml. You are using the upstream go binaries. They are distributed in a standard tarball, not as a pkgsrc package, so just unpack the tarball and use it - do not use pkg_add.
A prepare step like this should probably work:

          prepare: |
            ftp https://go.dev/dl/go${{matrix.go}}.netbsd-amd64.tar.gz
            rm -fr /usr/local/go && tar -C /usr/local -xf go${{matrix.go}}.netbsd-amd64.tar.gz
            ln -s /usr/local/go/bin/go /usr/local/bin

(Btw, cross-compilation to NetBSD should also work as usual in go.)

TotallyGamerJet · 2024-10-15T11:57:36Z

Thanks for the help. I'm getting some weird error when opening the archive. Thoughts?

(Btw, cross-compilation to NetBSD should also work as usual in go.)

This PR currently only supports Cgo. Once I get it in a usable state I can work on getting the entirely go version working which would enable cross compiling

0-wiz-0 · 2024-10-15T12:12:34Z

I see:

 ln -s /usr/local/go/bin/go /usr/local/bin
  /usr/bin/bash /home/runner/work/_actions/vmactions/netbsd-vm/v1/run.sh execSSHSH
  Config file: netbsd-10.0.conf
  FFFFFFFFFFFFFFFF:error:0A000126:SSL routines:ssl3_read_n:unexpected eof while reading:/usr/src/crypto/external/bsd/openssl/dist/ssl/record/rec_layer_s3.c:303:

you can ignore this, it's a bogus warning that will be fixed in 10.1.

  tar: could not chdir to '/usr/local'
  
  ln: /usr/local/bin: No such file or directory

Seems we need to add

mkdir /usr/local

before the tar command.
I didn't know that the target directory needed to exist first, sorry.

TotallyGamerJet · 2025-03-08T15:37:27Z

It's definitely there! Why doesn't it see it?

.github/scripts/bsd_tests.sh

.github/workflows/test.yml

hajimehoshi · 2025-03-08T15:52:02Z

.github/workflows/test.yml

+            export PATH=$PATH:/usr/local/go/bin/
+
+            chmod +x .github/scripts/bsd_tests.sh
+          run: bash .github/scripts/bsd_tests.sh


Isn't this already in a vm? In this case, shouldn't we copy the bsd_test.sh into the vm?

The repo is checked out which includes the bsd_tests.sh file. There isn't a need to copy it I don't think

https://github.com/ebitengine/purego/actions/runs/13739026602/job/38426088637#step:4:1323

I don't think this result indicates the file existence...

I see the .github folder though in that ls call

Ok it looks like it's not there at least in FreeBSD

. .. .cshrc .k5login .login .profile .sh_history .shrc .ssh go1.20.14.freebsd-amd64.tar.gz work ./.ssh: . .. authorized_keys config id_rsa id_rsa.pub known_hosts chmod: .github/scripts/bsd_tests.sh: No such file or directory

I'm not sure but what about $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh?

closer now since some of the NetBSD ones passed. FreeBSD still failed tho

Interesting, $GITHUB_WORKSPACE seems empty now...

hajimehoshi · 2025-03-08T16:43:10Z

.github/scripts/bsd_tests.sh

@@ -0,0 +1,79 @@
+#!/bin/bash


If bash command is not found, does this work?

If we want to use bash, we need to specify the correct path (/usr/bin/bash or /usr/local/bin/bash? I don't know...)

hajimehoshi · 2025-03-08T16:44:44Z

.github/scripts/bsd_tests.sh

+
+# SPDX-License-Identifier: Apache-2.0
+# SPDX-FileCopyrightText: 2025 The Ebitengine Authors
+


Let's add set -e to abort this script whenever any command fails.

EDIT: Hmm this might work only with Bash.

hajimehoshi · 2025-03-08T17:04:34Z

I'm trying https://github.com/hajimehoshi/purego/tree/pr/268 right now..

hajimehoshi · 2025-03-08T17:08:49Z

Maybe we can use regular actions? I don't know... https://github.com/vmactions/netbsd-vm?tab=readme-ov-file#7-custom-shell

hajimehoshi · 2025-03-08T18:59:07Z

https://github.com/hajimehoshi/purego/actions/runs/13740503731/job/38429163182 Mine worked. Feel free to copy it.

diff --git a/.github/scripts/bsd_tests.sh b/.github/scripts/bsd_tests.sh
index 6bbc34b..fb1c51e 100755
--- a/.github/scripts/bsd_tests.sh
+++ b/.github/scripts/bsd_tests.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 # SPDX-License-Identifier: Apache-2.0
 # SPDX-FileCopyrightText: 2025 The Ebitengine Authors
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 6e4b92c..257decf 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -149,7 +149,8 @@ jobs:
       run:
         shell: bash
     steps:
-      - uses: actions/checkout@v4
+      - name: Chckout
+        uses: actions/checkout@v4
       - name: Run in freebsd
         if: matrix.os == 'FreeBSD'
         uses: vmactions/freebsd-vm@v1
@@ -159,11 +160,8 @@ jobs:
             fetch https://go.dev/dl/go${{matrix.go}}.freebsd-amd64.tar.gz
             rm -fr /usr/local/go && tar -C /usr/local -xf go${{matrix.go}}.freebsd-amd64.tar.gz
             ln -s /usr/local/go/bin/go /usr/local/bin
-            ls -a -R
             chmod +x $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh
-          run: |
-            ls -a -R
-            $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh
+          run: $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh
       - name: Run in netbsd
         # there are no prebuilt download links for these versions of Go for NetBSD
         if: matrix.os == 'NetBSD' && !startsWith(matrix.go, '1.18.') && !startsWith(matrix.go, '1.19.') && !startsWith(matrix.go, '1.20.')

The points are:

$GITHUB_WORKSPACE is available.
Bash doesn't exist in VMs.
Use #!/bin/sh for shebangs.
Run script by just specifying the file name directly.

hajimehoshi · 2025-03-08T19:13:16Z

Ugh, this might not work well.. I'm investigating now.

An experimental version hajimehoshi@fc9e26c passed the test, but hajimehoshi@420b528 doesn't. Why...??

hajimehoshi · 2025-03-08T19:29:03Z

https://github.com/hajimehoshi/purego/actions/runs/13740761223/job/38429706509 OK, exporting PATH doesn't work in separate items. Now this change worked!

diff --git a/.github/scripts/bsd_tests.sh b/.github/scripts/bsd_tests.sh
index fb1c51e..1c5b9d2 100755
--- a/.github/scripts/bsd_tests.sh
+++ b/.github/scripts/bsd_tests.sh
@@ -10,6 +10,8 @@
 
 echo "Running tests on $(uname -a) at $PWD"
 
+PATH=$PATH:/usr/local/go/bin
+
 # verify Go is available
 go version
 
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index f660bb2..205c3ab 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -149,7 +149,8 @@ jobs:
       run:
         shell: bash
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout
+        uses: actions/checkout@v4
       - name: Run in freebsd
         if: matrix.os == 'FreeBSD'
         uses: vmactions/freebsd-vm@v1
@@ -158,7 +159,6 @@ jobs:
           prepare: |
             fetch https://go.dev/dl/go${{matrix.go}}.freebsd-amd64.tar.gz
             rm -fr /usr/local/go && tar -C /usr/local -xf go${{matrix.go}}.freebsd-amd64.tar.gz
-            ln -s /usr/local/go/bin/go /usr/local/bin
             chmod +x $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh
           run: $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh
       - name: Run in netbsd
@@ -172,7 +172,5 @@ jobs:
             ftp https://go.dev/dl/go${{matrix.go}}.netbsd-amd64.tar.gz
             mkdir /usr/local
             rm -fr /usr/local/go && tar -C /usr/local -xf go${{matrix.go}}.netbsd-amd64.tar.gz
-            ln -s /usr/local/go/bin/go /usr/local/bin
-            export PATH=$PATH:/usr/local/go/bin/
             chmod +x $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh
           run: $GITHUB_WORKSPACE/.github/scripts/bsd_tests.sh

TotallyGamerJet added 12 commits August 15, 2024 22:31

CGO support for Netbsd

10556e5

missing build tag

5068751

syscallArgs

92769ac

syscall15Args

000117c

some more

b23644e

build tag

68d652c

test

cf0745d

build tag for netbsd

3c3731e

some more stuff needed fixing

e87d728

ignore tests

0b92ec5

github actions

68c9fa4

include go

4d82012

hajimehoshi reviewed Aug 19, 2024

View reviewed changes

dlfcn_test.go Outdated Show resolved Hide resolved

hajimehoshi reviewed Aug 19, 2024

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

.github/workflows/test.yml Outdated Show resolved Hide resolved

hajimehoshi and others added 9 commits October 14, 2024 19:52

examples/window: replace deprecated functions (ebitengine#269)

f37da23

all: remove dependencies on golang.org/x/sys (ebitengine#271)

f8c7742

The example still has the dependency on golang.org/x/sys. Updates ebitengine#270

Clarify Example section and Dl* windows equivalents (ebitengine#274)

128551e

purego: mention LoadLibraryEx at Dlopen (ebitengine#275)

5ad9415

Updates ebitengine#273

examples: remove depdencies on golang.org/x/sys/windows (ebitengine#278)

c3f4c9c

Closes ebitengine#270

all: release v0.9.0-alpha

f091b66

test

570751c

fix install Go on freebsd

4b324b2

fix install Go on freebsd

7ab8812

TotallyGamerJet added 2 commits October 15, 2024 07:33

fix install Go

3b55709

remove Go versions that dl doesn't have downloads for

ec53690

mkdir

49cf092

TotallyGamerJet added 2 commits March 8, 2025 10:27

fix misspelling

25f17fc

ls to debug

2a6247c

ensure it is executable and then bash directly

3b59667

hajimehoshi reviewed Mar 8, 2025

View reviewed changes

.github/scripts/bsd_tests.sh Outdated Show resolved Hide resolved

.github/scripts/bsd_tests.sh Outdated Show resolved Hide resolved

newline and license

75cbcfc

hajimehoshi reviewed Mar 8, 2025

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

hajimehoshi reviewed Mar 8, 2025

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

TotallyGamerJet added 2 commits March 8, 2025 10:45

use "go version" for retrieving version

b0aba43

fix misspelling

e7e4a0e

hajimehoshi reviewed Mar 8, 2025

View reviewed changes

TotallyGamerJet added 6 commits March 8, 2025 10:53

don't run on version that aren't downloadable

5fda596

ls everything

9616e78

ls for freebsd

f6b5e0a

$GITHUB_WORKSPACE/

d7c63f1

remove bash

a5d18b0

ls inside "run:"

d0a90a9

hajimehoshi reviewed Mar 8, 2025

View reviewed changes

updates for freebsd

f2e19f3

TotallyGamerJet added 2 commits March 8, 2025 14:23

try bash again

961e360

yes install bash

19e4a72

sh

74c6bf6

TotallyGamerJet merged commit 1bd362f into ebitengine:main Mar 8, 2025
35 checks passed

TotallyGamerJet deleted the issue-249_netbsd branch March 8, 2025 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for NetBSD #268

Add support for NetBSD #268

TotallyGamerJet commented Aug 18, 2024 •

edited

Loading

TotallyGamerJet commented Oct 15, 2024

0-wiz-0 commented Oct 15, 2024

TotallyGamerJet commented Oct 15, 2024 •

edited

Loading

0-wiz-0 commented Oct 15, 2024

TotallyGamerJet commented Mar 8, 2025

hajimehoshi Mar 8, 2025

TotallyGamerJet Mar 8, 2025

hajimehoshi Mar 8, 2025

TotallyGamerJet Mar 8, 2025

TotallyGamerJet Mar 8, 2025

hajimehoshi Mar 8, 2025

TotallyGamerJet Mar 8, 2025

hajimehoshi Mar 8, 2025

hajimehoshi Mar 8, 2025

hajimehoshi Mar 8, 2025

hajimehoshi Mar 8, 2025 •

edited

Loading

hajimehoshi commented Mar 8, 2025

hajimehoshi commented Mar 8, 2025

hajimehoshi commented Mar 8, 2025 •

edited

Loading

hajimehoshi commented Mar 8, 2025 •

edited

Loading

hajimehoshi commented Mar 8, 2025 •

edited

Loading


		# SPDX-License-Identifier: Apache-2.0
		# SPDX-FileCopyrightText: 2025 The Ebitengine Authors

Add support for NetBSD #268

Add support for NetBSD #268

Conversation

TotallyGamerJet commented Aug 18, 2024 • edited Loading

What issue is this addressing?

What type of issue is this addressing?

What this PR does | solves

TotallyGamerJet commented Oct 15, 2024

0-wiz-0 commented Oct 15, 2024

TotallyGamerJet commented Oct 15, 2024 • edited Loading

0-wiz-0 commented Oct 15, 2024

TotallyGamerJet commented Mar 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hajimehoshi Mar 8, 2025 • edited Loading

Choose a reason for hiding this comment

hajimehoshi commented Mar 8, 2025

hajimehoshi commented Mar 8, 2025

hajimehoshi commented Mar 8, 2025 • edited Loading

hajimehoshi commented Mar 8, 2025 • edited Loading

hajimehoshi commented Mar 8, 2025 • edited Loading

TotallyGamerJet commented Aug 18, 2024 •

edited

Loading

TotallyGamerJet commented Oct 15, 2024 •

edited

Loading

hajimehoshi Mar 8, 2025 •

edited

Loading

hajimehoshi commented Mar 8, 2025 •

edited

Loading

hajimehoshi commented Mar 8, 2025 •

edited

Loading

hajimehoshi commented Mar 8, 2025 •

edited

Loading