Skip to content

Commit

Permalink
Switch internally mutating methods to &mut self (#32)
Browse files Browse the repository at this point in the history
* Switch multi-frame capture and file comments methods to &mut self

* Add new entry to CHANGELOG.md, reorder entry for #24
  • Loading branch information
ebkalderon authored May 18, 2019
1 parent 6a01ca4 commit 22351fe
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
* Switch to Circle CI Rust 1.34.1 image.

### Fixed
* Fix erroneous doc comments (PR #24).
* Switch `set_capture_file_comments()` and `trigger_multi_frame_capture()` to
take `&mut self` (PR #32).
* Unimplement `Clone`, `Send`, and `Sync` for `RenderDoc` struct (PR #29).
* Correct default setting in the `get_set_capture_option()` unit test.
* Fix improperly designed `launch_replay_ui()` method, update `triangle` example
to match.
* Set correct RenderDoc library path for Android clients.
* Add missing trait re-exports to `prelude` module (PR #31).
* Fix erroneous doc comments (PR #24).

## [0.4.0] - 2018-09-16
### Added
Expand Down
4 changes: 2 additions & 2 deletions src/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ pub trait RenderDocV110: RenderDocV100 {
///
/// Data is saved to a capture log file at the location specified via
/// `set_log_file_path_template()`.
fn trigger_multi_frame_capture(&self, num_frames: u32) {
fn trigger_multi_frame_capture(&mut self, num_frames: u32) {
unsafe {
(self.entry_v110().TriggerMultiFrameCapture.unwrap())(num_frames);
}
Expand Down Expand Up @@ -353,7 +353,7 @@ pub trait RenderDocV120: RenderDocV112 {
unsafe fn entry_v120(&self) -> &EntryV120;

#[allow(missing_docs)]
fn set_capture_file_comments<'a, P, C>(&self, path: P, comments: C)
fn set_capture_file_comments<'a, P, C>(&mut self, path: P, comments: C)
where
P: Into<Option<&'a str>>,
C: AsRef<str>,
Expand Down

0 comments on commit 22351fe

Please sign in to comment.