Fix bug deserializing jsonrpc version from Value #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that `serde_json::from_value` always provides an owned `String` to the deserializer instead of a borrowed `str` as previously assumed. This means that while `serde_json::from_str` works fine, deserializing with `serde_json::from_value` fails with the following error: ``` invalid type: string "2.0", expected a borrowed string ``` Changing `jsonrpc::Version` to deserialize the string into a `Cow<'de, str>` instead of a plain `str` fixes this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
serde_json::from_valuesupport forjsonrpc::{Incoming,Outgoing}messages.It turns out that
serde_json::from_valuealways provides an ownedStringto the deserializer instead of a borrowedstras previously assumed. This means that whileserde_json::from_strworks fine, deserializing withserde_json::from_valuefails with the following error:Changing
jsonrpc::Versionto deserialize the string into aCow<'de, str>instead of a plainstrfixes this problem.Bug was first identified in wasm-lsp/wasm-lsp-server#47 (comment).
Sorry for the breakage, @darinmorrison! ❤️